lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 7 Dec 2013 11:06:44 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Gary Rookard <garyrookard@...il.com> Cc: gregkh@...uxfoundation.org, devel@...verdev.osuosl.org, lisa@...apiadmin.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH 5/9] Staging: bcm: DDRInit: replaced C99 comments. On Fri, Dec 06, 2013 at 11:52:35PM -0500, Gary Rookard wrote: > This is the fifth patch of a series. > > Signed-off-by: Gary Alan Rookard <garyrookard@...il.com> > --- > On branch staging-next > drivers/staging/bcm/DDRInit.c | 270 +++++++++++++++++++++--------------------- > 1 file changed, 135 insertions(+), 135 deletions(-) > > diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c > index cb4dd53..1a08b17 100644 > --- a/drivers/staging/bcm/DDRInit.c > +++ b/drivers/staging/bcm/DDRInit.c > @@ -5,15 +5,15 @@ > #define DDR_DUMP_INTERNAL_DEVICE_MEMORY 0xBFC02B00 > #define MIPS_CLOCK_REG 0x0f000820 > > - //DDR INIT-133Mhz > -#define T3_SKIP_CLOCK_PROGRAM_DUMP_133MHZ 12 //index for 0x0F007000 > -static struct bcm_ddr_setting asT3_DDRSetting133MHz[] = {// # DPLL Clock Setting > + /* DDR INIT-133Mhz */ > +#define T3_SKIP_CLOCK_PROGRAM_DUMP_133MHZ 12 /* index for 0x0F00700 */0 ^^^ This also breaks the build... :( Really, this is not ok. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists