linux-kernel - Re: Oddball Author from on commit for rcu tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAB=NE6V3PMXC19k9nwv0fXfjCt7u+bY44-zBStSi_SFiDbVW8Q@mail.gmail.com>
Date:	Sun, 8 Dec 2013 17:34:13 +0100
From:	"Luis R. Rodriguez" <mcgrof@...not-panic.com>
To:	Fengguang Wu <fengguang.wu@...el.com>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:	Julia Lawall <julia.lawall@...6.fr>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: Oddball Author from on commit for rcu tree

On Sun, Dec 8, 2013 at 5:32 PM, Luis R. Rodriguez
<mcgrof@...not-panic.com> wrote:
> I see this commit on linux-next:
>
> commit 705e5a58432b56f9821d6884341575c02536661f
> Author: Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> Date:   Thu Oct 10 11:08:33 2013 -0700
>
>     rcu: Fix coccinelle warnings
>
>     This commit fixes the following coccinelle warning:
>
>     kernel/rcu/tree.c:712:9-10: WARNING: return of 0/1 in function
>     'rcu_lockdep_current_cpu_online' with return type bool
>
>     Return statements in functions returning bool should use
>      true/false instead of 1/0.
>      Generated by: coccinelle/misc/boolreturn.cocci
>
>     Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
>     Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
>
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index 3049950..f8c0299 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -725,7 +725,7 @@ bool rcu_lockdep_current_cpu_online(void)
>         bool ret;
>
>         if (in_nmi())
> -               return 1;
> +               return true;
>         preempt_disable();
>         rdp = this_cpu_ptr(&rcu_sched_data);
>         rnp = rdp->mynode;
>
>
> Although I'm enjoying the usage of the Generated by tag thing, the
> From of that patch had the Signed-off-by tag, not sure how that
> happened but if its going to happen more better we catch it now. Also
> not sure if that will trigger a flag to Greg and Corbet's stat scripts
> but just in case Cc'd.

Doh, too late:

mcgrof@...ro ~/linux-next (git::master)$ git log --pretty="%an" | grep Signed
Signed-off-by: Fengguang Wu
Signed-off-by: Sony Chacko
Signed-off-by: Sony Chacko
Signed-off-by: Jan Kara
Signed-off-by: Darren Hart
Signed-off-by: Darren Hart
Signed-off-by: Darren Hart
Signed-off-by: Wu Fengguang
Signed-off-by: Peter Stokes
Signed-off by Yi Yang
Signed-off-by@...genet.net":Simon

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/