linux-kernel - Re: [PATCH V4] cpufreq: suspend governors on system suspend/hibernate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3466098.C5M665z3nb@vostro.rjw.lan>
Date:	Sun, 08 Dec 2013 01:34:36 +0100
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	Bjørn Mork <bjorn@...k.no>,
	Viresh Kumar <viresh.kumar@...aro.org>,
	Lists linaro-kernel <linaro-kernel@...ts.linaro.org>,
	Patch Tracking <patches@...aro.org>,
	"cpufreq@...r.kernel.org" <cpufreq@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Nishanth Menon <nm@...com>,
	Stephen Warren <swarren@...dotorg.org>,
	Kgene Kim <kgene.kim@...sung.com>,
	linux-samsung-soc <linux-samsung-soc@...r.kernel.org>,
	linux-tegra@...r.kernel.org, jinchoi@...adcom.com,
	Lan Tianyu <tianyu.lan@...el.com>,
	Sebastian Capella <sebastian.capella@...aro.org>,
	Jonghwan Choi <jhbird.choi@...sung.com>
Subject: Re: [PATCH V4] cpufreq: suspend governors on system suspend/hibernate

On Saturday, December 07, 2013 04:24:09 PM Paul Bolle wrote:
> On Sat, 2013-12-07 at 12:01 +0100, Bjørn Mork wrote:
> > Sorry to be making noise here again, but I was eager to verify that the
> > fixes in v3.13-rc3 were OK on my system.  Unfortunately it seems this
> > patch completely broke suspend for me.  Hibernete ended up with a blank
> > console and no visible activity, without ever writing any image to disk.
> > 
> > There really weren't that many suspects between v3.13-rc2 and v3.13-rc3,
> > so I went directly to reverting 5a87182aa21d ("cpufreq: suspend
> > governors on system suspend/hibernate") which fixed the problem. I
> > didn't bother debugging it further from there. I don't think there is
> > anything magic about my system which should make this problem specific
> > to it.
> > 
> > I am still using the acpi-cpufreq driver on an old x86_64 laptop if that
> > matters.
> 
> On an x86 (32 bits) laptop hibernate also broke in v3.13-rc3. On that
> machine hibernation itself worked, or at least seemed to work, but the
> machine would basically stop after thawing (directly after loading the
> hibernation image).
> 
> And reverting commit 5a87182aa21d ("cpufreq: suspend governors on system
> suspend/hibernate"), on top of v3.13-rc3, also lead to a successful
> hibernation/thaw cycle.

OK, reverted.

I'll send a pull request with that revert shortly.

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/