linux-kernel - Re: [PATCH] dell-laptop: add parameter to disable the backlight device.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52A47CCC.50000@linux.com>
Date:	Sun, 08 Dec 2013 15:06:04 +0100
From:	Levente Kurusa <levex@...ux.com>
To:	Alex Davis <alex14641@...oo.com>,
	"mjg59@...f.ucam.org" <mjg59@...f.ucam.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dell-laptop: add parameter to disable the backlight device.


2013-12-08 14:40, Alex Davis:
> I have a Dell Inspiron N7010 Laptop with Intel graphics. When the dell-laptop module is loaded,
> two backlight device devices are created; dell_backlight, and intel_backlight from the Intel
> graphics driver. The dell_backlight device is non-functional, but the graphics subsystem uses
> it instead of the functioning intel_backlight device. The result is that, when running KDE,
> screen brightness cannot be controlled. I've added a module parameter, disable_backlight
> which, when true, will disable the dell_backlight device, and leave only the intel_backlight:
> with this, screen brightness can be controlled.
>

Hi,

I think it would be better if we could figure out why the
dell_blacklight device is not working rather than disabling it.


Regarding your patch, it creates a memory leak as you:
  * allocate a platform device
  * you add it
  * you allocated a page for SMI

Your if(disable_blacklight) code should go
where it checks the DMI.

-- 
Regards,
Levente Kurusa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/