linux-kernel - Re: [PATCH v2 2/2] arm: omap: remove *.auto* from device names given in usb_bind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52A55E2C.7070500@ti.com>
Date:	Mon, 9 Dec 2013 11:37:40 +0530
From:	Kishon Vijay Abraham I <kishon@...com>
To:	<balbi@...com>, Tony Lindgren <tony@...mide.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>
CC:	Javier Martinez Canillas <javier@...hile0.org>,
	Russell King <linux@....linux.org.uk>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>, <linux-usb@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] arm: omap: remove *.auto* from device names given
 in usb_bind_phy

Hi,

On Saturday 07 December 2013 02:38 AM, Felipe Balbi wrote:
> Hi,
>
> On Fri, Dec 06, 2013 at 01:14:38PM +0100, Javier Martinez Canillas wrote:
>> On Fri, Dec 6, 2013 at 1:06 PM, Kishon Vijay Abraham I <kishon@...com> wrote:
>>> Previously MUSB wrapper (OMAP) device used PLATFORM_DEVID_AUTO while creating
>>> MUSB core device. So in usb_bind_phy (binds the controller with the PHY), the
>>> device name of the controller had *.auto* in it. Since with using
>>> PLATFORM_DEVID_AUTO, there is no way to know the exact device name in advance,
>>> the data given in usb_bind_phy became obsolete and usb_get_phy was failing.
>>> So MUSB wrapper was modified not to use PLATFORM_DEVID_AUTO. Corresponding
>>> change is done in board file here.
>>>
>>> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
>>> ---
>>>   arch/arm/mach-omap2/board-2430sdp.c        |    2 +-
>>>   arch/arm/mach-omap2/board-3430sdp.c        |    2 +-
>>>   arch/arm/mach-omap2/board-cm-t35.c         |    2 +-
>>>   arch/arm/mach-omap2/board-devkit8000.c     |    2 +-
>>>   arch/arm/mach-omap2/board-ldp.c            |    2 +-
>>>   arch/arm/mach-omap2/board-omap3beagle.c    |    2 +-
>>>   arch/arm/mach-omap2/board-omap3logic.c     |    2 +-
>>>   arch/arm/mach-omap2/board-omap3pandora.c   |    2 +-
>>>   arch/arm/mach-omap2/board-omap3stalker.c   |    2 +-
>>>   arch/arm/mach-omap2/board-omap3touchbook.c |    2 +-
>>>   arch/arm/mach-omap2/board-overo.c          |    2 +-
>>>   arch/arm/mach-omap2/board-rx51.c           |    2 +-
>>>   12 files changed, 12 insertions(+), 12 deletions(-)
>>>
>>
>> You can drop this patch since boards files are being removed for v3.14
>
> if we can drop this patch, the whole series is invalid, since we'll be
> using DT phandles to find PHYs going forward, no ?
>
yeah. But in one of the other threads, Tony seemed ok to take a patch 
that fixes the same issue in mach-omap2/twl-common.c. So it's better to 
confirm with Tony.

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/