linux-kernel - Re: [PATCH 16/20] audit: allow GET, SET, USER MSG operations in audit namespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52A52146.1060804@cn.fujitsu.com>
Date:	Mon, 09 Dec 2013 09:47:50 +0800
From:	Gao feng <gaofeng@...fujitsu.com>
To:	"Serge E. Hallyn" <serge@...lyn.com>
CC:	linux-kernel@...r.kernel.org, linux-audit@...hat.com,
	toshi.okajima@...fujitsu.com,
	containers@...ts.linux-foundation.org, serge.hallyn@...ntu.com,
	eparis@...hat.com, ebiederm@...ssion.com, sgrubb@...hat.com
Subject: Re: [PATCH 16/20] audit: allow GET, SET, USER MSG operations in audit
 namespace

On 12/07/2013 06:00 AM, Serge E. Hallyn wrote:
> Quoting Gao feng (gaofeng@...fujitsu.com):
>> 1, remove the permission check of pid namespace. it's no reason
>>    to deny un-init pid namespace to operate audit subsystem.
>>
>> 2, only allow init user namespace and init audit namespace to
>>    operate list/add/del rule, tty set, trim, make equiv operations.
>>
>> 3, allow audit namespace to get/set audit configuration, send
>>    userspace audit message.
>>
>> Signed-off-by: Gao feng <gaofeng@...fujitsu.com>
>> ---
>>  kernel/audit.c | 13 ++++++-------
>>  1 file changed, 6 insertions(+), 7 deletions(-)
>>
>> diff --git a/kernel/audit.c b/kernel/audit.c
>> index 095f54d..c4d4291 100644
>> --- a/kernel/audit.c
>> +++ b/kernel/audit.c
>> @@ -573,11 +573,7 @@ out:
>>  static int audit_netlink_ok(struct sk_buff *skb, u16 msg_type)
>>  {
>>  	int err = 0;
>> -
>> -	/* Only support the initial namespaces for now. */
>> -	if ((current_user_ns() != &init_user_ns) ||
>> -	    (task_active_pid_ns(current) != &init_pid_ns))
>> -		return -EPERM;
>> +	struct audit_namespace *ns = current->nsproxy->audit_ns;
>>  
>>  	switch (msg_type) {
>>  	case AUDIT_LIST:
>> @@ -586,6 +582,7 @@ static int audit_netlink_ok(struct sk_buff *skb, u16 msg_type)
>>  		return -EOPNOTSUPP;
>>  	case AUDIT_GET:
>>  	case AUDIT_SET:
>> +		break;
> 
> So, these AUDIT_SET and AUDIT_GET go from requiring CAP_AUDIT_CONTROL
> to not needing any privs at all?
> 

My mistake, there should be a check such as
ns_capable(ns, CAP_AUDIT_CONTROL).

will fix in next version.

Thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/