linux-kernel - Re: [PATCH v3] ARM: davinci: aemif: get rid of davinci-nand driver dependency on aemif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52A58633.7060705@ti.com>
Date:	Mon, 9 Dec 2013 10:58:27 +0200
From:	"ivan.khoronzhuk" <ivan.khoronzhuk@...com>
To:	Sekhar Nori <nsekhar@...com>
CC:	Santosh Shilimkar <santosh.shilimkar@...com>, <rob@...dley.net>,
	<linux@....linux.org.uk>, <mark.rutland@....com>,
	<devicetree@...r.kernel.org>, <grygorii.strashko@...com>,
	<pawel.moll@....com>, <swarren@...dotorg.org>,
	<ijc+devicetree@...lion.org.uk>, <galak@...nel.crashing.org>,
	<rob.herring@...xeda.com>, <linux-kernel@...r.kernel.org>,
	<linux-mtd@...ts.infradead.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<computersforpeace@...il.com>, <dwmw2@...radead.org>
Subject: Re: [PATCH v3] ARM: davinci: aemif: get rid of davinci-nand driver
 dependency on aemif

On 12/06/2013 11:04 PM, Sekhar Nori wrote:
> On 12/5/2013 11:41 PM, Ivan Khoronzhuk wrote:
> 
>> diff --git a/arch/arm/mach-davinci/board-mityomapl138.c b/arch/arm/mach-davinci/board-mityomapl138.c
>> index 7aa105b..98a66ff 100644
>> --- a/arch/arm/mach-davinci/board-mityomapl138.c
>> +++ b/arch/arm/mach-davinci/board-mityomapl138.c
>> @@ -432,6 +432,9 @@ static void __init mityomapl138_setup_nand(void)
>>   {
>>   	platform_add_devices(mityomapl138_devices,
>>   				 ARRAY_SIZE(mityomapl138_devices));
>> +
>> +	if (davinci_aemif_setup(&mityomapl138_nandflash_device))
>> +		pr_warn("%s: Cannot configure AEMIF.\n", __func__);
>>   }
> 
> I must be missing something, but exactly why is this required for
> board-mityomapl138.c?
> 
> Thanks,
> Sekhar
> 

board-mityomapl138.c - only one board file with NAND_BUSWIDTH_16 option set in pdata.
By default bus width is treated as 8 bit, in another case we have to set it.
Currently bus width setup is done in davinci_aemif_setup(). So, to set bus width
correctly we have to call davinci_aemif_setup() for board in question.

-- 
Regards,
Ivan Khoronzhuk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/