lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <1386559847-33012-1-git-send-email-huawei.libin@huawei.com>
Date:	Mon, 9 Dec 2013 11:30:47 +0800
From:	Libin <huawei.libin@...wei.com>
To:	Tejun Heo <tj@...nel.org>
CC:	<guohanjun@...wei.com>, <wangyijing@...wei.com>,
	<linux-kernel@...r.kernel.org>
Subject: [PATCH] workqueue: Remove redundant call for pwq_adjust_max_active

From: Li Bin <huawei.libin@...wei.com>

In __alloc_workqueue_key(), alloc_and_link_pwqs() already called
pwq_adjust_max_active() to update the pwq's max_active, but after
that there is a redundant call for pwq_adjust_max_active. It is
meanless, remove it.

Signed-off-by: Li Bin <huawei.libin@...wei.com>
---
 kernel/workqueue.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index c66912be..31cbe1d 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -4247,11 +4247,6 @@ struct workqueue_struct *__alloc_workqueue_key(const char *fmt,
 	 */
 	mutex_lock(&wq_pool_mutex);
 
-	mutex_lock(&wq->mutex);
-	for_each_pwq(pwq, wq)
-		pwq_adjust_max_active(pwq);
-	mutex_unlock(&wq->mutex);
-
 	list_add(&wq->list, &workqueues);
 
 	mutex_unlock(&wq_pool_mutex);
-- 
1.8.2.2


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ