linux-kernel - Re: [PATCH 1/3] usb: phy-generic: Add GPIO based ChipSelect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131209040705.GB20608@saruman.home>
Date:	Sun, 8 Dec 2013 22:07:05 -0600
From:	Felipe Balbi <balbi@...com>
To:	Chris Ruehl <chris.ruehl@...ys.com.hk>
CC:	<balbi@...com>, <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] usb: phy-generic: Add GPIO based ChipSelect

Hi,

On Mon, Dec 09, 2013 at 09:45:30AM +0800, Chris Ruehl wrote:
> On Saturday, December 07, 2013 04:24 AM, Felipe Balbi wrote:
> >Hi,
> >
> >On Mon, Dec 02, 2013 at 03:05:17PM +0800, Chris Ruehl wrote:
> >>@@ -231,27 +249,40 @@ static int usb_phy_gen_xceiv_probe(struct platform_device *pdev)
> >>  		return -ENOMEM;
> >>
> >>  	nop->reset_active_low = true;	/* default behaviour */
> >>+	nop->cs_active_low = true;
> >>
> >>  	if (dev->of_node) {
> >>  		struct device_node *node = dev->of_node;
> >>  		enum of_gpio_flags flags;
> >>+		enum of_gpio_flags csflags;
> >>
> >>  		if (of_property_read_u32(node, "clock-frequency",&clk_rate))
> >>  			clk_rate = 0;
> >>
> >>  		needs_vcc = of_property_read_bool(node, "vcc-supply");
> >>+
> >>  		nop->gpio_reset = of_get_named_gpio_flags(node, "reset-gpios",
> >>  								0,&flags);
> >>+
> >
> >two unrelated changes
> >
> >>  		if (nop->gpio_reset == -EPROBE_DEFER)
> >>  			return -EPROBE_DEFER;
> >>
> >>  		nop->reset_active_low = flags&  OF_GPIO_ACTIVE_LOW;
> >>
> >>+		nop->gpio_chipselect = of_get_named_gpio_flags(node, "cs-gpios",
> >>+								0,&csflags);
> >>+		if (gpio_is_valid(nop->gpio_chipselect))
> >>+			nop->cs_active_low = csflags&  OF_GPIO_ACTIVE_LOW;
> >>+
> >>  	} else if (pdata) {
> >>  		type = pdata->type;
> >>  		clk_rate = pdata->clk_rate;
> >>  		needs_vcc = pdata->needs_vcc;
> >>  		nop->gpio_reset = pdata->gpio_reset;
> >>+		nop->gpio_chipselect = pdata->gpio_chipselect;
> >>+	} else {
> >>+		nop->gpio_reset = -1;
> >
> >This line is already going upstream, please remove it, i'll handle the
> >conflict later.
> >
> 
> Beause the rest of the patch set is not ready to make it in the
> upstream, I will checkout latest linux-next and send the patch again
> as a single patch.

no, please *never* base any patches off of linux-next. That tree gets
recreated every day and can never be considered stable. Aim at using a
tag from Linus instead (v3.13-rc3, for example). It's a much better
development point than linux-next.

In case patch doesn't apply cleanly, different maintainers will have
their choice of rebasing it themselves or asking author to rebase on a
specific branch.

By default, however, use a tag from Linus.

cheers

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)