linux-kernel - Re: [PATCH] perf tools: Fix bug for perf kvm report without guestmount.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52A5FA13.9000000@cn.fujitsu.com>
Date:	Mon, 09 Dec 2013 12:12:51 -0500
From:	Dongsheng Yang <yangds.fnst@...fujitsu.com>
To:	David Ahern <dsahern@...il.com>
CC:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf tools: Fix bug for perf kvm report without guestmount.

On 12/08/2013 10:42 PM, David Ahern wrote:
> On 12/9/13, 8:20 AM, Dongsheng Yang wrote:
>> How about introduce an option named --guestpid? Then we can make the
>> usage of perf kvm
>> more clear:
>>      * perf kvm --guestkallsyms --guestmodules --guestpid
>> [top|record|report]
>>          This usage is for only one guest and will not resolve the
>> symbols from other guests.
>
> If there is only 1 guest then there should not be a problem right? You 
> give perf a single guest kallsyms as the "default" and it works. 
> --guestpid adds no value in that case.

Yes, if there is only one guest is running, "default" guest is "the" 
guest. Then with my patch in this thread applied, it works well.

But consider this scenario, there are two guests are running, but we 
need to record-report one of them.

--guestmount can achieve this request, but as a shortcut of guestmount, 
--guest{kallysms, modules} dose not
support it well, right? So, I think we can discard the default guest, 
and use guestpid in record-report.
>
> David
>
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/