linux-kernel - Re: [PATCH -next] x86, kaslr: remove unused including <linux/version.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jLq_CHdSNuCgenTZzyBaa=CjvnFOioxVyqRdB3FYro08A@mail.gmail.com>
Date:	Mon, 9 Dec 2013 10:03:57 -0800
From:	Kees Cook <keescook@...omium.org>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, yongjun_wei@...ndmicro.com.cn,
	"x86@...nel.org" <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] x86, kaslr: remove unused including <linux/version.h>

On Sat, Dec 7, 2013 at 5:02 AM, Wei Yongjun <weiyj.lk@...il.com> wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>
> Remove including <linux/version.h> that don't need it.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>

Thanks, yeah, ultimately utsrelease.h had everything that was needed.

Acked-by: Kees Cook <keescook@...omium.org>

> ---
>  arch/x86/boot/compressed/aslr.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/boot/compressed/aslr.c b/arch/x86/boot/compressed/aslr.c
> index 84be175..90a21f4 100644
> --- a/arch/x86/boot/compressed/aslr.c
> +++ b/arch/x86/boot/compressed/aslr.c
> @@ -10,7 +10,6 @@
>  #include <linux/uts.h>
>  #include <linux/utsname.h>
>  #include <generated/utsrelease.h>
> -#include <linux/version.h>
>
>  /* Simplified build-specific string for starting entropy. */
>  static const char build_str[] = UTS_RELEASE " (" LINUX_COMPILE_BY "@"
>

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/