linux-kernel - Re: [PATCH V2 2/2] pinctrl: tegra: add pinmux controller driver for Tegra124

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52A60B9A.7010709@wwwdotorg.org>
Date:	Mon, 09 Dec 2013 11:27:38 -0700
From:	Stephen Warren <swarren@...dotorg.org>
To:	Laxman Dewangan <ldewangan@...dia.com>, linus.walleij@...aro.org
CC:	rob.herring@...xeda.com, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, rob@...dley.net,
	thierry.reding@...il.com, grant.likely@...aro.org,
	devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
	Ashwini Ghuge <aghuge@...dia.com>
Subject: Re: [PATCH V2 2/2] pinctrl: tegra: add pinmux controller driver for
 Tegra124

On 12/09/2013 03:32 AM, Laxman Dewangan wrote:
> From: Ashwini Ghuge <aghuge@...dia.com>
> 
> This adds a driver for the Tegra124 pinmux, and required
> parameterization data for Tegra124.
> 
> The driver uses the common Tegra pincontrol driver utility
> functions to implement the majority of the driver.
> 
> This driver is not compatible with the earlier NVIDIA's SoCs,
> hence add new compatibile as "nvidia,tegra124-pinmux".
> 
> Originally written by Ashwini Gguhe.
> Thierry:
> 	- Cleanups in patches.
> ldewangan:
>         - Fix some entries for groups.
> 	- Fix MUX enums and group sequence.

> +static const struct pinctrl_pin_desc  tegra124_pins[] = {

Still two spaces there...

BTW, I said the following before for both patches; please make sure you
add this to the commit description...

Acked-by: Stephen Warren <swarren@...dia.com>

Even if I didn't say it before, it's certainly now,

Tested-by: Stephen Warren <swarren@...dia.com>

(I also tested your patches that add the pinctrl DT entries to the
Venice2 DT file. Thanks.)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/