linux-kernel - Re: [PATCH] mm: add show num_poisoned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1312091405170.11026@chino.kir.corp.google.com>
Date:	Mon, 9 Dec 2013 14:05:25 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Naoya Horiguchi <n-horiguchi@...jp.nec.com>
cc:	Xishi Qiu <qiuxishi@...wei.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Michal Hocko <mhocko@...e.cz>, Mel Gorman <mgorman@...e.de>,
	LKML <linux-kernel@...r.kernel.org>, linux-mm@...ck.org
Subject: Re: [PATCH] mm: add show num_poisoned_pages when oom

On Mon, 9 Dec 2013, Naoya Horiguchi wrote:

> > Show num_poisoned_pages when oom, it is helpful to find the reason.
> > 
> > Signed-off-by: Xishi Qiu <qiuxishi@...wei.com>
> > ---
> >  lib/show_mem.c |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> > 
> > diff --git a/lib/show_mem.c b/lib/show_mem.c
> > index 5847a49..1cbdcd8 100644
> > --- a/lib/show_mem.c
> > +++ b/lib/show_mem.c
> > @@ -46,4 +46,7 @@ void show_mem(unsigned int filter)
> >  	printk("%lu pages in pagetable cache\n",
> >  		quicklist_total_size());
> >  #endif
> > +#ifdef CONFIG_MEMORY_FAILURE
> > +	printk("%lu pages poisoned\n", atomic_long_read(&num_poisoned_pages));
> > +#endif
> >  }
> 
> I think that just "poisoned" could be confusing because this word seems to
> be used also in other context (like slab and list_debug handling.)
> "hwpoisoned" or "hardware corrupted" (which is the same label in /proc/meminfo)
> looks better to me.
> 

Ah, good point.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/