linux-kernel - Re: [Xen-devel] [RFC][PATCH 3/3] timekeeping: Fix potential lost pv notification of time change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52A795F3.9040107@linaro.org>
Date:	Tue, 10 Dec 2013 14:30:11 -0800
From:	John Stultz <john.stultz@...aro.org>
To:	Jan Beulich <JBeulich@...e.com>
CC:	David Vrabel <david.vrabel@...rix.com>,
	Richard Cochran <richardcochran@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>, xen-devel@...ts.xen.org,
	Prarit Bhargava <prarit@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>,
	stable <stable@...r.kernel.org>
Subject: Re: [Xen-devel] [RFC][PATCH 3/3] timekeeping: Fix potential lost
 pv notification of time change

On 12/10/2013 12:13 AM, Jan Beulich wrote:
>>>> On 10.12.13 at 06:09, John Stultz <john.stultz@...aro.org> wrote:
>>  static cycle_t logarithmic_accumulation(struct timekeeper *tk, cycle_t offset,
>> -						u32 shift)
>> +						u32 shift, int *action)
> With plain int used here, ...
>
>> @@ -1369,7 +1369,7 @@ static void update_wall_time(void)
>>  	struct timekeeper *tk = &shadow_timekeeper;
>>  	cycle_t offset;
>>  	int shift = 0, maxshift;
>> -	unsigned int action;
>> +	unsigned int action = 0;
> ... and unsigned int used here, ...
>
>> @@ -1404,7 +1404,7 @@ static void update_wall_time(void)
>>  	maxshift = (64 - (ilog2(ntp_tick_length())+1)) - 1;
>>  	shift = min(shift, maxshift);
>>  	while (offset >= tk->cycle_interval) {
>> -		offset = logarithmic_accumulation(tk, offset, shift);
>> +		offset = logarithmic_accumulation(tk, offset, shift, &action);
> ... does this compile without warning for you?

It does compile without a warning, but I'll fix it none the less!

Thanks for pointing this out!
-john

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/