linux-kernel - Re: [PATCH RESEND 1/2] proc: change return values while get_proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131210150241.5b741b8754112b1ab6d3abd6@linux-foundation.org>
Date:	Tue, 10 Dec 2013 15:02:41 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Rui Xiang <rui.xiang@...wei.com>
Cc:	<linux-kernel@...r.kernel.org>,
	Alexander Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH RESEND 1/2] proc: change return values while
 get_proc_task err

On Mon, 9 Dec 2013 20:11:54 +0800 Rui Xiang <rui.xiang@...wei.com> wrote:

> While getting proc task error, it shoule return -ESRCH.
> 
> ...
>
> --- a/fs/proc/base.c
> +++ b/fs/proc/base.c
> @@ -174,9 +174,10 @@ static int get_task_root(struct task_struct *task, struct path *root)
>  static int proc_cwd_link(struct dentry *dentry, struct path *path)
>  {
>  	struct task_struct *task = get_proc_task(dentry->d_inode);
> -	int result = -ENOENT;
> +	int result = -ESRCH;

I suppose so.  But there is risk here of breaking existing applications
and I don't think this problem is serious enough to justify that risk?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/