lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 09 Dec 2013 18:16:04 -0600 From: Mike Christie <michaelc@...wisc.edu> To: Ethan Zhao <ethan.kernel@...il.com> CC: konrad.wilk@...cle.com, pjones@...hat.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH] [SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset() On 12/09/2013 03:37 AM, Ethan Zhao wrote: > From: "Ethan Zhao" <ethan.kernel@...il.com> > > Load and unload iscsi_ibft module will cause kernel memory leak, fix it > in scsi/iscsi_boot_sysfs.c iscsi_boot_destroy_kset(). > > Signed-off-by: Ethan Zhao <ethan.kernel@...il.com> > --- > drivers/scsi/iscsi_boot_sysfs.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/iscsi_boot_sysfs.c b/drivers/scsi/iscsi_boot_sysfs.c > index 14c1c8f..680bf6f 100644 > --- a/drivers/scsi/iscsi_boot_sysfs.c > +++ b/drivers/scsi/iscsi_boot_sysfs.c > @@ -490,5 +490,6 @@ void iscsi_boot_destroy_kset(struct iscsi_boot_kset *boot_kset) > iscsi_boot_remove_kobj(boot_kobj); > > kset_unregister(boot_kset->kset); > + kfree(boot_kset); > } > EXPORT_SYMBOL_GPL(iscsi_boot_destroy_kset); Thanks. Patch looks ok. It is probably best to just kill the iscsi_boot_kset use and use the kset directly. To do that, we would need to make kset's list a klist and add some iterators then modify iscsi_boot_sysfs.c and iscsi_ibft.c to use them instead of using the iscsi_boot_kset->kobj_list. I will work on a patch to do this. But for now your patch is ok. Reviewed-by: Mike Christie <michaelc@...wisc.edu> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists