linux-kernel - Re: [PATCH] xen/debugfs: Check debugfs initialization before using it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABawtvMbMUf-tj77m9t=t45R3-1e8gE--8QZ7neU-HuSjGcveA@mail.gmail.com>
Date:	Tue, 10 Dec 2013 16:03:41 +0800
From:	Ethan Zhao <ethan.kernel@...il.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	raghavendra.kt@...ux.vnet.ibm.com,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] xen/debugfs: Check debugfs initialization before using it

On Tue, Dec 10, 2013 at 2:40 AM, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Mon, Dec 09, 2013 at 09:42:23PM +0800, Ethan Zhao wrote:
>> Greg,
>>     I am the man who built a Xen dom0, but couldn't see debugfs
>> directory and files as expected. there is no warning or tip for me to
>> enable the CONFIG_DEBUG_FS=y in .config , it cost me minutes to figure
>> out what's
>> the matter. and I know should check defugfs config and initialization as
>> zswap_debugfs, tracer_debugfs ,rproc_debugfs did. Is it useless ? if
>> it could save me just 1 minute next time ?
>
> So you would want a "warning" showing up for every single part of the
> kernel that uses debugfs for when it isn't enabled?  That doesn't make
> too much sense now, does it?

No, It is nice and like sun light when someone is struggling with the
bugs in darkness,
if some tips or warning output to them.

You have forgotten the initial stage you met :)

>
> If you need/want debugfs then enable it in the kernel build, it's not
> that hard, right?

of coz, not hard. and It not so hard to merge it too.

Thanks,
Ethan
>
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/