linux-kernel - Re: rcu: Avoid irq disable in rcu_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131210000521.GH4208@linux.vnet.ibm.com>
Date:	Mon, 9 Dec 2013 16:05:21 -0800
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Christoph Lameter <cl@...ux.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: rcu: Avoid irq disable in rcu_cpu_kthread

On Thu, Dec 05, 2013 at 09:06:55PM +0000, Christoph Lameter wrote:
> Once we have the per cpu patchset merged we could do the following [it
> even works without that patchset but the __this_cpu ops will not do
> preemption checks]. Would this work?

Looks plausible at first glance.  But are you really seeing performance
issues with this code?  It is only compiled into the kernel when you build
with CONFIG_RCU_BOOST=y -- are you actually using that for your workloads?

							Thanx, Paul

> Subject: rcu: Avoid irq disable in rcu_cpu_kthread
> 
> The use of this_cpu ops avoids numerous address calculations
> and allows to avoid the irq enable/disable sequence through a
> low latency non locking this_cpu_xchg.
> 
> Signed-off-by: Christoph Lameter <cl@...ux.com>
> 
> Index: linux/kernel/rcu/tree_plugin.h
> ===================================================================
> --- linux.orig/kernel/rcu/tree_plugin.h	2013-12-03 11:32:23.322999660 -0600
> +++ linux/kernel/rcu/tree_plugin.h	2013-12-03 11:32:23.312999941 -0600
> @@ -1417,33 +1417,29 @@ static int rcu_cpu_kthread_should_run(un
>   */
>  static void rcu_cpu_kthread(unsigned int cpu)
>  {
> -	unsigned int *statusp = this_cpu_ptr(&rcu_cpu_kthread_status);
> -	char work, *workp = this_cpu_ptr(&rcu_cpu_has_work);
> +	char work;
>  	int spincnt;
> 
>  	for (spincnt = 0; spincnt < 10; spincnt++) {
>  		trace_rcu_utilization(TPS("Start CPU kthread@..._wait"));
>  		local_bh_disable();
> -		*statusp = RCU_KTHREAD_RUNNING;
> -		this_cpu_inc(rcu_cpu_kthread_loops);
> -		local_irq_disable();
> -		work = *workp;
> -		*workp = 0;
> -		local_irq_enable();
> +		__this_cpu_write(rcu_cpu_kthread_status, RCU_KTHREAD_RUNNING);
> +		__this_cpu_inc(rcu_cpu_kthread_loops);
> +		work = this_cpu_xchg(rcu_cpu_has_work, 0);
>  		if (work)
>  			rcu_kthread_do_work();
>  		local_bh_enable();
> -		if (*workp == 0) {
> +		if (__this_cpu_read(rcu_cpu_has_work) == 0) {
>  			trace_rcu_utilization(TPS("End CPU kthread@..._wait"));
> -			*statusp = RCU_KTHREAD_WAITING;
> +			__this_cpu_write(rcu_cpu_kthread_status, RCU_KTHREAD_WAITING);
>  			return;
>  		}
>  	}
> -	*statusp = RCU_KTHREAD_YIELDING;
> +	__this_cpu_write(rcu_cpu_kthread_status, RCU_KTHREAD_YIELDING);
>  	trace_rcu_utilization(TPS("Start CPU kthread@..._yield"));
>  	schedule_timeout_interruptible(2);
>  	trace_rcu_utilization(TPS("End CPU kthread@..._yield"));
> -	*statusp = RCU_KTHREAD_WAITING;
> +	__this_cpu_write(rcu_cpu_kthread_status, RCU_KTHREAD_WAITING);
>  }
> 
>  /*
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/