lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Dec 2013 00:41:41 -0800 From: Bjorn Andersson <bjorn.andersson@...ymobile.com> To: Stephen Boyd <sboyd@...eaurora.org> CC: Rob Herring <rob.herring@...xeda.com>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Stephen Warren <swarren@...dotorg.org>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Rob Landley <rob@...dley.net>, Linus Walleij <linus.walleij@...aro.org>, Grant Likely <grant.likely@...aro.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH v2 2/3] pinctrl: Add msm8x74 configuration On Fri 06 Dec 14:22 PST 2013, Stephen Boyd wrote: > > +config PINCTRL_MSM8X74 > > + bool "Qualcomm 8x74 pin controller driver" > > + select PINCTRL_MSM > > No help? > I could write something up, although I guess someone will add a select PINCTRL_MSM8X74 in the mach-msm Kconfig and then we're done with it. > > + .ctl_reg = 0x1000 + 0x10 * id , \ > > Weird trailing space here. > Oops. > Also, do we ever plan to have anything more than the gpio pins and the > sdc pins? It seems like we spend a lot of space describing exactly the > same thing in these structs for each of the 146 gpio pins when we could > just know that range 0 to 146 is gpio pins and have different code for > that part vs the 6 or something sd pins. > We have to have a pingroup list, so I did look at having that list referencing a common object with the gpio/sdc specific data. But just having it in one large blob is the way that other pinctrl drivers does it and hence a common problem to pinctrl and multi-platform arm support. I have not seen any code in the open referencing the other pins, so I left them out for now. > > + > > +static struct of_device_id msm8x74_pinctrl_of_match[] = { > > const? > Of course. > > > > + > > +static int __init msm8x74_pinctrl_init(void) > > +{ > > + return platform_driver_register(&msm8x74_pinctrl_driver); > > +} > > +arch_initcall(msm8x74_pinctrl_init); > > + > > +static void __exit msm8x74_pinctrl_exit(void) > > +{ > > + platform_driver_unregister(&msm8x74_pinctrl_driver); > > +} > > +module_exit(msm8x74_pinctrl_exit); > > Why not module_platform_driver()? I thought pinctrl supported deferred > probing? > As this pinctrl/gpiochip/interrupt-controller is a fairly central part of the system there's plenty of things that would just end up being deferred. Most other pinctrl driver does arch_initcall or core_initcall, so I followed suit and brought it in early. Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists