linux-kernel - Re: [PATCH v2 4/7] mm/migrate: remove putback_lru_pages, fix comment on putback_movable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Dec 2013 17:51:47 +0900
From:	Joonsoo Kim <iamjoonsoo.kim@....com>
To:	Wanpeng Li <liwanp@...ux.vnet.ibm.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Mel Gorman <mgorman@...e.de>, Rik van Riel <riel@...hat.com>,
	Rafael Aquini <aquini@...hat.com>,
	Naoya Horiguchi <n-horiguchi@...jp.nec.com>,
	Christoph Lameter <cl@...ux.com>, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, Vlastimil Babka <vbabka@...e.cz>,
	Zhang Yanfei <zhangyanfei@...fujitsu.com>
Subject: Re: [PATCH v2 4/7] mm/migrate: remove putback_lru_pages, fix comment
 on putback_movable_pages

> >@@ -1704,6 +1688,12 @@ int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma,
> > 	nr_remaining = migrate_pages(&migratepages, alloc_misplaced_dst_page,
> > 				     node, MIGRATE_ASYNC, MR_NUMA_MISPLACED);
> > 	if (nr_remaining) {
> >+		if (!list_empty(&migratepages)) {
> >+			list_del(&page->lru);
> >+			dec_zone_page_state(page, NR_ISOLATED_ANON +
> >+					page_is_file_cache(page));
> >+			putback_lru_page(page);
> >+		}
> > 		putback_lru_pages(&migratepages);
> 
> You should remove this line. Otherwise,

Yes, you are right. I will send next version. T_T

> 
> Reviewed-by: Wanpeng Li <liwanp@...ux.vnet.ibm.com>

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/