lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Dec 2013 14:52:40 +0100 From: Tomasz Figa <t.figa@...sung.com> To: Heiko Stübner <heiko@...ech.de> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Slaby <jslaby@...e.cz>, linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org, Kukjin Kim <kgene.kim@...sung.com>, Chander Kashyap <chander.kashyap@...aro.org> Subject: Re: [PATCH] serial: samsung: move clock deactivation below uart registration Hi Heiko, On Thursday 05 of December 2013 00:54:38 Heiko Stübner wrote: > Commit 60e93575476f (serial: samsung: enable clock before clearing pending > interrupts during init) added handling of the controller clock during init. > > On most systems this clock is also one of the baud_clock sources and > possibly used by the earlycon and thus already enabled by the bootloader. > > Therefore a gap exists between s3c24xx_serial_init_port disabling the > clock and an attached console reenabling it, making the transition from > earlycon to regular console possibly hang the system - as seen on my > S3C2442 based Freerunner today. > > Therefore move the disabling of the clock from s3c24xx_serial_init_port > below the uart port registration, effectively creating an overlap and > keeping the clock running non-stop if the console wants to grab this port. > > Signed-off-by: Heiko Stuebner <heiko@...ech.de> > --- > drivers/tty/serial/samsung.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) Makes sense. Reviewed-by: Tomasz Figa <t.figa@...sung.com> Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists