linux-kernel - RE: [PATCH 3.4 01/25] crypto: scatterwalk - Set the chain pointer indication bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <986457BC66A4884EBFFDEFEBEB20F84C0B1EBBAA@satlexdag04.amd.com>
Date:	Tue, 10 Dec 2013 14:46:46 +0000
From:	"Lendacky, Thomas" <Thomas.Lendacky@....com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"stable@...r.kernel.org" <stable@...r.kernel.org>,
	Herbert Xu <herbert@...dor.apana.org.au>
Subject: RE: [PATCH 3.4 01/25] crypto: scatterwalk - Set the chain pointer
 indication bit

Hi Greg,

This patch is probably not needed in any of the stable branches, but if
you do add it you'll need to also include a patch that changes the use
of an sg_page to an sg_chain_ptr to prevent a BUG_ON when CONFIG_DEBUG_SG
is enabled (http://marc.info/?l=linux-crypto-vger&m=138627061905651&w=2).

Thanks,
Tom

-----Original Message-----
From: Greg Kroah-Hartman [mailto:gregkh@...uxfoundation.org] 
Sent: Tuesday, December 10, 2013 2:00 AM
To: linux-kernel@...r.kernel.org
Cc: Greg Kroah-Hartman; stable@...r.kernel.org; Lendacky, Thomas; Herbert Xu
Subject: [PATCH 3.4 01/25] crypto: scatterwalk - Set the chain pointer indication bit

3.4-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Tom Lendacky <thomas.lendacky@....com>

commit 41da8b5adba77e22584f8b45f9641504fa885308 upstream.

The scatterwalk_crypto_chain function invokes the scatterwalk_sg_chain function to chain two scatterlists, but the chain pointer indication bit is not set.  When the resulting scatterlist is used, for example, by sg_nents to count the number of scatterlist entries, a segfault occurs because sg_nents does not follow the chain pointer to the chained scatterlist.

Update scatterwalk_sg_chain to set the chain pointer indication bit as is done by the sg_chain function.

Signed-off-by: Tom Lendacky <thomas.lendacky@....com>
Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

---
 include/crypto/scatterwalk.h |    1 +
 1 file changed, 1 insertion(+)

--- a/include/crypto/scatterwalk.h
+++ b/include/crypto/scatterwalk.h
@@ -36,6 +36,7 @@ static inline void scatterwalk_sg_chain(  {
 	sg_set_page(&sg1[num - 1], (void *)sg2, 0, 0);
 	sg1[num - 1].page_link &= ~0x02;
+	sg1[num - 1].page_link |= 0x01;
 }

 static inline struct scatterlist *scatterwalk_sg_next(struct scatterlist *sg)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/