linux-kernel - Re: [PATCHv4] clocksource: dw_apb_timer_of: Fix read_sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1386690820.6211.4.camel@linux-builds1>
Date:	Tue, 10 Dec 2013 09:53:40 -0600
From:	Dinh Nguyen <dinguyen@...era.com>
To:	Ingo Molnar <mingo@...nel.org>
CC:	<dinh.linux@...il.com>, <daniel.lezcano@...aro.org>,
	<tglx@...utronix.de>, <jamie@...ieiles.com>,
	<linus.walleij@...aro.org>, <linux-kernel@...r.kernel.org>,
	<heiko@...ech.de>
Subject: Re: [PATCHv4] clocksource: dw_apb_timer_of: Fix read_sched_clock

On Tue, 2013-12-10 at 16:53 +0100, Ingo Molnar wrote:
> * dinguyen@...era.com <dinguyen@...era.com> wrote:
> 
> > From: Dinh Nguyen <dinguyen@...era.com>
> > 
> > The read_sched_clock should return the ~value because the clock is a
> > countdown implementation. read_sched_clock() should be the same as
> > __apbt_read_clocksource().
> > 
> > Maintain backwards compatibility for "dw-apb-timer-sp" and
> > "dw-apb-timer-osc".
> 
> Are these two independent fixes? If yes then they should be in 
> separate patches. In general we want to apply minimized, obvious, 
> single-purpose fix patches.

Yes, I will split them.

Thanks,
Dinh
> 
> Thanks,
> 
> 	Ingo
> 



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/