linux-kernel - Re: [PATCHv5 1/2] clocksource: dw_apb_timer_of: Fix read_sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Dec 2013 19:53:29 +0100
From:	Daniel Lezcano <daniel.lezcano@...aro.org>
To:	dinguyen@...era.com, dinh.linux@...il.com, mingo@...nel.org,
	tglx@...utronix.de
CC:	jamie@...ieiles.com, linus.walleij@...aro.org,
	linux-kernel@...r.kernel.org, heiko@...ech.de
Subject: Re: [PATCHv5 1/2] clocksource: dw_apb_timer_of: Fix read_sched_clock

On 12/10/2013 05:07 PM, dinguyen@...era.com wrote:
> From: Dinh Nguyen <dinguyen@...era.com>
>
> The read_sched_clock should return the ~value because the clock is a
> countdown implementation. read_sched_clock() should be the same as
>   __apbt_read_clocksource().
>
> Signed-off-by: Dinh Nguyen <dinguyen@...era.com>
> ---
> v5: Split up into 2 patches
> v4: Simplify the fix by simply returning ~__raw_readl(sched_io_base)
> v3: Use APBTMR_N_CURRENT_VALUE define in read_sched_clock()
> v2: Maintain backwards compatibility for "dw-apb-timer-sp" and
>        "dw-apb-timer-osc".
> ---
>   drivers/clocksource/dw_apb_timer_of.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/dw_apb_timer_of.c b/drivers/clocksource/dw_apb_timer_of.c
> index 45ba8ae..b29d7cd 100644
> --- a/drivers/clocksource/dw_apb_timer_of.c
> +++ b/drivers/clocksource/dw_apb_timer_of.c
> @@ -108,7 +108,7 @@ static void __init add_clocksource(struct device_node *source_timer)
>
>   static u64 read_sched_clock(void)
>   {
> -	return __raw_readl(sched_io_base);
> +	return ~__raw_readl(sched_io_base);
>   }

Dinh,

I dropped the patch moving the macro definitions as it is not applied 
for urgent and I assume it is not needed for the 3.14 as there are no 
more patches depending on it.

   -- Daniel

>   static const struct of_device_id sptimer_ids[] __initconst = {
>


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/