linux-kernel - Re: [patch net-next] ipv6: log autoconfiguration failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131210.221613.1663906151846555561.davem@davemloft.net>
Date:	Tue, 10 Dec 2013 22:16:13 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	dvlasenk@...hat.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kuznet@....inr.ac.ru, jmorris@...ei.org, yoshfuji@...ux-ipv6.org,
	kaber@...sh.net, jpirko@...hat.com
Subject: Re: [patch net-next] ipv6: log autoconfiguration failures

From: Denys Vlasenko <dvlasenk@...hat.com>
Date: Mon,  9 Dec 2013 17:26:48 +0100

> If ipv6 auto-configuration does not work, currently it's hard
> to track what's going on. This change adds log messages
> (at debug level) on every code path where ipv6 autoconf fails.
> 
> Signed-off-by: Denys Vlasenko <dvlasenk@...hat.com>

Add statistics, those are more globally useful.

> +		pr_debug("IPv6 addrconf: %s: address length %d != %s\n",
> +				dev->name, dev->addr_len, "ETH_ALEN");

And this is not indented correctly, the arguments on lines after the
first must line up exactly to the column after the openning parenthesis
of the function call.

The idea isn't to use just TABs until you think it looks nice, rather
you should use the appropriate number of SPACE and TAB characters
necessary to reach the exact column.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/