linux-kernel - RE: [PATCH] usb: phy: Initilize the spinlock in notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 10 Dec 2013 22:19:46 -0800
From:	Neil Zhang <zhangwm@...vell.com>
To:	Neil Zhang <zhangwm@...vell.com>, "balbi@...com" <balbi@...com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] usb: phy: Initilize the spinlock in notifier


> -----Original Message-----
> From: Neil Zhang [mailto:zhangwm@...vell.com]
> Sent: 2013年12月11日 13:05
> To: balbi@...com; gregkh@...uxfoundation.org
> Cc: linux-usb@...r.kernel.org; linux-kernel@...r.kernel.org; Neil Zhang
> Subject: [PATCH] usb: phy: Initilize the spinlock in notifier
> 
> We need to initilize every spinlock before use it.
> So lets initilize the spinlock in notifier when add a new phy device.
> 
> Signed-off-by: Neil Zhang <zhangwm@...vell.com>
> ---
>  drivers/usb/phy/phy.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c index
> 1b74523..479ceb8 100644
> --- a/drivers/usb/phy/phy.c
> +++ b/drivers/usb/phy/phy.c
> @@ -367,6 +367,8 @@ int usb_add_phy_dev(struct usb_phy *x)
>  		return -EINVAL;
>  	}
> 
> +	spin_lock_init(&x->notifier.lock);
> +
>  	spin_lock_irqsave(&phy_lock, flags);
>  	list_for_each_entry(phy_bind, &phy_bind_list, list)
>  		if (!(strcmp(phy_bind->phy_dev_name, dev_name(x->dev))))
> --
> 1.7.9.5

Please ignore this patch and check another one.
Sorry for this noise.

Best Regards,
Neil Zhang