Message-ID: <871324710.20131211191104@eikelenboom.it>
Date:	Wed, 11 Dec 2013 19:11:04 +0100
From:	Sander Eikelenboom <linux@...elenboom.it>
To:	"Luis R. Rodriguez" <mcgrof@...not-panic.com>
CC:	"Berg, Johannes" <johannes.berg@...el.com>,
	"Grumbach, Emmanuel" <emmanuel.grumbach@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"ilw@...ux.intel.com" <ilw@...ux.intel.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"John W. Linville" <linville@...driver.com>
Subject: Re: [cfg80211 / iwlwifi] setting wireless regulatory domain doesn't work.


Wednesday, December 11, 2013, 6:53:07 PM, you wrote:

> On Wed, Dec 11, 2013 at 6:28 PM, Sander Eikelenboom
> <linux@...elenboom.it> wrote:
>> Wednesday, December 11, 2013, 6:14:16 PM, you wrote:
>>> Yeap, that's the case for Intel Atheros, and I think nowadays new
>>> broadcom upstream drivers too. Users should not have to be involved on
>>> setting the regulatory domain, everything should just work
>>> automatically.
>>
>> Erhmm yes that works, under the assumption that the device is not leaving the country it was programmed for at the factory.

> Moving out of a region that you purchased a device is called to "world
> roam". Believe it or not some devices are designed with the intent you
> do not take it out of a country. The Playstation comes to mind as an
> example but I believe some Apple tablets are also in the same
> situation. Some devices like mobile phones obviously need to support
> world roaming and they do, what they do then is build architecture to
> support a base set and then rely on your APs around to see the country
> IE to determine region. Some other devices rely on cellular base
> station information, but that is allowed only in a few countries right
> now and in the US at least this requires some sort of special review
> from FCC on the design. We support all this in the Linux kernel today,
> its up to system integrators to do things and certify things properly.

>> (Or you like to be limited in your abilities, channel 12 and 13 are legal here)
>> That there is a restriction on boot or on first use, i can understand. Crippling a device for it's life time though.

> The best way to address all this is by automatic region awareness and
> doing the right thing on devices, this however requires good
> architecture / calibration data  / etc and all that needs to be
> verified by the system integrators, and finally they need to be
> certified. If you want to hack your firmware and software go at it,
> just be aware there are reasons for things.

Well the general problem seems to be "we don't trust the user" so we FORCE him to the lowest
common denominator (without a way to overrule that) so he is forced to operate *well* within the law.

>>> It doesn't seem like you are getting your original requests getting
>>> processed, so I don't think CRDA is passing it. Can you verify running
>>> from CRDA code:
>>
>> They don't get processed unless i remove the return from the code as i indicated.
>> If i remove that return it processes the request.
>>
>>> ./regdbdump /usr/lib/crda/regulatory.bin
>>
>> Although it's in a different location on Debian, /lib/crda/regulatory.bin
>> the dump seems fine.

> OK thanks. Can you send a patch of what exact change you made, it was
> unclear from the paste you made.

> diff -u file.c.orig file.c

Well i just did a pull from wireless-next, to try Avinash Patil's patch.
net/wireless/reg.c had already changed much so i couldn't apply his patch without.

With his patch it sets the regulatory domain, although as now expected i still can not use channels 12 and 13 yet,
probably due to those firmware restrictions.

His patch is copy pasted below.


>   Luis


---------- Forwarded message ----------
From: "Avinash Patil" <patila@...vell.com>
Date: Dec 6, 2013 8:31 PM
Subject: [RFC] cfg80211: set regulatory request processed for initiator core
To: <johannes@...solutions.net>, <linux-wireless@...r.kernel.org>
Cc:

During cfg80211 init, cfg80211 initializes regulatory to set to
world domain. Here we dont set last request processed flag.
This results into further request set to pending indefinitely.

This patch fixes this by setting last request to processed.

Signed-off-by: Avinash Patil <patila@...vell.com>
---
 net/wireless/reg.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/net/wireless/reg.c b/net/wireless/reg.c
index ec54e1a..70a8f0a 100644
--- a/net/wireless/reg.c
+++ b/net/wireless/reg.c
@@ -1670,6 +1670,8 @@ static void reg_process_hint(struct
regulatory_request *reg_request)
        switch (reg_request->initiator) {
        case NL80211_REGDOM_SET_BY_CORE:
                reg_process_hint_core(reg_request);
+               nl80211_send_reg_change_event(reg_request);
+               reg_set_request_processed();
                return;
        case NL80211_REGDOM_SET_BY_USER:
                treatment = reg_process_hint_user(reg_request);
--
1.7.3.4

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists