linux-kernel - Re: [RFC PATCH] drivers: char: Add a dynamic clock for the trace clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABPqkBTufgMk=iqXM87+psUeLd865QF9tCEVHT6hwT4=TtetfQ@mail.gmail.com>
Date:	Wed, 11 Dec 2013 20:30:10 +0100
From:	Stephane Eranian <eranian@...gle.com>
To:	Josh Triplett <josh@...htriplett.org>
Cc:	Sonny Rao <sonnyrao@...omium.org>,
	LKML <linux-kernel@...r.kernel.org>,
	John Stultz <john.stultz@...aro.org>,
	Pawel Moll <pawell.moll@....com>,
	Olof Johansson <olof@...om.net>,
	Ingo Molnar <mingo@...nel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [RFC PATCH] drivers: char: Add a dynamic clock for the trace clock

Sonny,

Your patch has a couple of problems for me:
 - requires CONFIG_TRACING

You should directly invoke getrawmonotonic()
 and inline the code from trace_clock_getres().

That's how I managed to compile your kernel module on my system.


On Mon, Dec 9, 2013 at 8:49 AM, Josh Triplett <josh@...htriplett.org> wrote:
> On Fri, Dec 06, 2013 at 04:34:11PM -0800, Sonny Rao wrote:
>> Based on a suggestion from John Stultz.
>>
>> This adds a dynamic clock device which can be used with clock_gettime
>> to sample the clock source used for time stamping trace events in the
>> kernel.  The only use for this clock source is to associate user space
>> events with kernel events on a given kernel.  It is explicitly not
>> supposed to be used as a generic time source and won't necessarily be
>> consistent between kernels.
>>
>> Signed-off-by: Sonny Rao <sonnyrao@...omium.org>
>
> Reviewed-by: Josh Triplett <josh@...htriplett.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/