linux-kernel - Re: [PATCH v0 54/71] perf script: Always allow fields 'addr' and 'cpu' for itrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52A8BFDC.1090205@gmail.com>
Date:	Wed, 11 Dec 2013 12:41:16 -0700
From:	David Ahern <dsahern@...il.com>
To:	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
CC:	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	Frederic Weisbecker <fweisbec@...il.com>,
	Jiri Olsa <jolsa@...hat.com>, Mike Galbraith <efault@....de>,
	Namhyung Kim <namhyung@...il.com>,
	Paul Mackerras <paulus@...ba.org>,
	Stephane Eranian <eranian@...gle.com>,
	Andi Kleen <ak@...ux.intel.com>,
	Adrian Hunter <adrian.hunter@...el.com>
Subject: Re: [PATCH v0 54/71] perf script: Always allow fields 'addr' and
 'cpu' for itrace

On 12/11/13, 5:37 AM, Alexander Shishkin wrote:
> From: Adrian Hunter <adrian.hunter@...el.com>
>
> If a file contains Instruction Tracing data then always allow
> fields 'addr' and 'cpu' to be selected as options for perf
> script.  This is necessary because Instruction Trace decoding
> may synthesize events with that information.

Why hardcode it? If it is present and the user opts for it then it will 
be printed. Why is the itrace check needed?

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/