linux-kernel - Re: [PATCH] hwmon: HIH-6130: Support I2C bus drivers without I2C_FUNC_SMBUS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52A8C25A.6000403@inov.pt>
Date:	Wed, 11 Dec 2013 19:51:54 +0000
From:	José Miguel Gonçalves <jose.goncalves@...v.pt>
To:	Guenter Roeck <linux@...ck-us.net>
CC:	Jean Delvare <khali@...ux-fr.org>, lm-sensors@...sensors.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: HIH-6130: Support I2C bus drivers without I2C_FUNC_SMBUS_QUICK

On 11-12-2013 19:29, Guenter Roeck wrote:
> On Wed, Dec 11, 2013 at 11:11:13AM +0000, José Miguel Gonçalves wrote:
>> Some I2C bus drivers do not allow zero-length data transfers which are
>> required to start a measurement with the HIH6130/1 sensor. Nevertheless,
>> we can overcome this limitation by writing a zero dummy byte. This byte
>> is ignored by the sensor and was verified to be working with the OMAP
>> I2C bus driver in a BeagleBone board.
>>
>> Signed-off-by: José Miguel Gonçalves <jose.goncalves@...v.pt>
> Applied, after simplifying write_length initialization a bit.
>
> Should this go to -stable ?

Any BeagleBone user that tries to use this sensor will encounter this issue. As 
this board is very popular, this will potentially solve the problems of many 
users. Nevertheless, it does not seems to me that this patch fixes "something 
critical", which is one of the conditions to be accepted in the -stable tree.

José Gonçalves
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/