linux-kernel - Re: [PATCH 1/6] kernfs: s/sysfs_dirent/kernfs_node/ and rename its friends accordingly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131211212238.GC20491@kroah.com>
Date:	Wed, 11 Dec 2013 13:22:38 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Tejun Heo <tj@...nel.org>
Cc:	linux-kernel@...r.kernel.org, neilb@...e.de,
	linus.walleij@...aro.org, ashutosh.dixit@...el.com,
	kbuild test robot <fengguang.wu@...el.com>
Subject: Re: [PATCH 1/6] kernfs: s/sysfs_dirent/kernfs_node/ and rename its
 friends accordingly

On Wed, Dec 11, 2013 at 02:11:53PM -0500, Tejun Heo wrote:
> kernfs has just been separated out from sysfs and we're already in
> full conflict mode.  Nothing can make the situation any worse.  Let's
> take the chance to name things properly.
> 
> This patch performs the following renames.
> 
> * s/sysfs_elem_dir/kernfs_elem_dir/
> * s/sysfs_elem_symlink/kernfs_elem_symlink/
> * s/sysfs_elem_attr/kernfs_elem_file/
> * s/sysfs_dirent/kernfs_node/
> * s/sd/kn/ in kernfs proper
> * s/parent_sd/parent/
> * s/target_sd/target/
> * s/dir_sd/parent/
> * s/to_sysfs_dirent()/rb_to_kn()/
> * misc renames of local vars when they conflict with the above
> 
> Because md, mic and gpio dig into sysfs details, this patch ends up
> modifying them.  All are sysfs_dirent renames and trivial.  While we
> can avoid these by introducing a dummy wrapping struct sysfs_dirent
> around kernfs_node, given the limited usage outside kernfs and sysfs
> proper, I don't think such workaround is called for.

Ugh, why are those drivers digging into sysfs core bits anyway?  I'll
look and see if they should be fixed up as well, as I really doubt a
"normal" driver should ever care about this type of thing...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/