| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <52A7C9D9.4080308@gmail.com>
Date: Wed, 11 Dec 2013 10:11:37 +0800
From: Chen Gang <gang.chen.5i5j@...il.com>
To: Seth Jennings <sjennings@...iantweb.net>
CC: Seth Jennings <sjenning@...ux.vnet.ibm.com>, linux-mm@...ck.org,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
James Hogan <james.hogan@...tec.com>
Subject: [PATCH v2] mm/zswap.c: add BUG() for default case in zswap_writeback_entry()
Recommend to add default case to avoid compiler's warning, although at
present, the original implementation is still correct.
The related warning (with allmodconfig for metag):
CC mm/zswap.o
mm/zswap.c: In function 'zswap_writeback_entry':
mm/zswap.c:537: warning: 'ret' may be used uninitialized in this function
Signed-off-by: Chen Gang <gang.chen.5i5j@...il.com>
---
mm/zswap.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/mm/zswap.c b/mm/zswap.c
index 5a63f78..f58a001 100644
--- a/mm/zswap.c
+++ b/mm/zswap.c
@@ -585,6 +585,10 @@ static int zswap_writeback_entry(struct zbud_pool *pool, unsigned long handle)
/* page is up to date */
SetPageUptodate(page);
+ break;
+
+ default:
+ BUG();
}
/* move it to the tail of the inactive list after end_writeback */
--
1.7.7.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists