linux-kernel - Re: [PATCH] leds: pwm: Remove a warning on non-DT platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 12 Dec 2013 09:35:39 -0800
From:	Bryan Wu <cooloney@...il.com>
To:	Olof Johansson <olof@...om.net>
Cc:	"rpurdie@...ys.net" <rpurdie@...ys.net>,
	Linux LED Subsystem <linux-leds@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] leds: pwm: Remove a warning on non-DT platforms

On Wed, Dec 11, 2013 at 4:11 PM, Olof Johansson <olof@...om.net> wrote:
> This removes a warning on non-DT-enabled platforms:
>
> drivers/leds/leds-pwm.c: In function 'led_pwm_create_of':
> drivers/leds/leds-pwm.c:88:22: warning: unused variable 'node'
>
> Really caused by the local variable that is assigned to and then never
> used. Just do away with the local var, it's not needed.
>
> Technically this code path can never be entered without DT enabled,
> since there's an earlier check about number of children in the calling
> function, but the compiler can't see that.
>

Great, actually we got an 0-Day kbuild warning about this. I'll merge
this fixing.

Thanks,
-Bryan

> Signed-off-by: Olof Johansson <olof@...om.net>
> ---
>  drivers/leds/leds-pwm.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c
> index b31d8e99..bf49547 100644
> --- a/drivers/leds/leds-pwm.c
> +++ b/drivers/leds/leds-pwm.c
> @@ -85,11 +85,10 @@ static inline size_t sizeof_pwm_leds_priv(int num_leds)
>  static int led_pwm_create_of(struct platform_device *pdev,
>                              struct led_pwm_priv *priv)
>  {
> -       struct device_node *node = pdev->dev.of_node;
>         struct device_node *child;
>         int ret;
>
> -       for_each_child_of_node(node, child) {
> +       for_each_child_of_node(pdev->dev.of_node, child) {
>                 struct led_pwm_data *led_dat = &priv->leds[priv->num_leds];
>
>                 led_dat->cdev.name = of_get_property(child, "label",
> --
> 1.7.10.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/