linux-kernel - Re: [RFC/RFT/PATCH V3] gpio: omap: refresh patch "be more aggressive with pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 Dec 2013 12:28:31 -0600
From:	Felipe Balbi <balbi@...com>
To:	Linus Walleij <linus.walleij@...aro.org>
CC:	Chao Xu <caesarxuchao@...il.com>,
	Linux-OMAP <linux-omap@...r.kernel.org>,
	"santosh.shilimkar@...com" <santosh.shilimkar@...com>,
	ext Kevin Hilman <khilman@...prootsystems.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	ext Tony Lindgren <tony@...mide.com>,
	Felipe Balbi <balbi@...com>, Kevin Hilman <khilman@...aro.org>,
	Nishanth Menon <nm@...com>
Subject: Re: [RFC/RFT/PATCH V3] gpio: omap: refresh patch "be more aggressive
 with pm_runtime" against v3.12-rc5

On Thu, Dec 12, 2013 at 07:19:35PM +0100, Linus Walleij wrote:
> On Sun, Dec 8, 2013 at 5:40 AM, Chao Xu <caesarxuchao@...il.com> wrote:
> 
> > From: Felipe Balbi <balbi@...com>
> >
> > try to keep gpio block suspended as much as possible.
> >
> > Tested with pandaboard and a sysfs exported gpio.
> >
> > Signed-off-by: Felipe Balbi <balbi at ti.com>
> >
> > [caesarxuchao@...il.com : Refreshed against v3.12-rc5, and added
> > revision check to enable aggressive pm_runtime on OMAP4-only. Because
> > am33xx_gpio_sysc.idlemodes seems to be wrongly marked as
> > SIDLE_SMART_WKUP, which might cause missed interrupts with this patch.
> > Tested on Pandaboard rev A2.]
> > Signed-off-by: Chao Xu <caesarxuchao@...il.com>
> > ---
> > changes since v2:
> > *add wrapper function to avoid 'is_aggressive_pm' check everywhere, as
> > suggested by Santosh Shilimkar
> > *fix format issue in commit log
> 
> I'm dropping this until you convince Kevin/Tony that this is
> the way to go.
> 
> One thing caught my eye, you add:
> 
> > +static void _aggressive_pm_runtime_get_sync(struct gpio_bank *bank)
> > +static void _aggressive_pm_runtime_put(struct gpio_bank *bank)
> (..)
> 
> Then everywhere:
> 
> > +       _aggressive_pm_runtime_get_sync(bank);
> (...)
> > +       _aggressive_pm_runtime_put(bank);
> 
> Aggressive, argh, runtime PM is agressive by definition. If you
> want to switch this on and off use the compile option
> to enable/disable runtime PM altogether and do not wrap it
> like this.

heh, OMAP doesn't work without pm_runtime.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)