linux-kernel - Re: [PATCH] cgroup: fix fail path in cgroup_load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 Dec 2013 13:45:06 -0500
From:	Tejun Heo <tj@...nel.org>
To:	Vladimir Davydov <vdavydov@...allels.com>
Cc:	linux-kernel@...r.kernel.org, cgroups@...r.kernel.org,
	devel@...nvz.org, Li Zefan <lizefan@...wei.com>
Subject: Re: [PATCH] cgroup: fix fail path in cgroup_load_subsys()

Hello,

On Thu, Dec 12, 2013 at 10:37:32PM +0400, Vladimir Davydov wrote:
> If so, I don't mind, but why? cgroup_unload_subsys() should never be
> called without properly initialized css.

Hmm.... I think it's generally preferable to reuse normal exit path
for error handling as much as possible.  Plus, the normal cgroup init
failure path behaves that way.  That said, it's more of a preference
and if you have technical argument, I'd be happy to give in. :)

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/