linux-kernel - Re: [PATCH] usb: host: xhci: Move suspend ops under PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131213052334.GA2403@psi-dev26.jf.intel.com>
Date:	Thu, 12 Dec 2013 21:23:34 -0800
From:	David Cohen <david.a.cohen@...ux.intel.com>
To:	Santosh Shilimkar <santosh.shilimkar@...com>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Sarah Sharp <sarah.a.sharp@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] usb: host: xhci: Move suspend ops under PM_SLEEP to
 avoid warning

On Thu, Dec 12, 2013 at 07:25:55PM -0800, David Cohen wrote:
> On Thu, Dec 12, 2013 at 09:01:04PM -0500, Santosh Shilimkar wrote:
> > On Thursday 12 December 2013 08:51 PM, David Cohen wrote:
> > > On Thu, Dec 12, 2013 at 08:06:24PM -0500, Santosh Shilimkar wrote:
> > >> Otherwise you get below build warnings
> > >>
> > >> drivers/usb/host/xhci-plat.c:201:12: warning: ‘xhci_plat_suspend’ defined but not used [-Wunused-function]
> > >> drivers/usb/host/xhci-plat.c:209:12: warning: ‘xhci_plat_resume’ defined but not used [-Wunused-function]
> > >>
> > >> Cc: Sarah Sharp <sarah.a.sharp@...ux.intel.com>
> > >> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > >> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@...com>
> > >> ---
> > >>  drivers/usb/host/xhci-plat.c |    4 ++--
> > >>  1 file changed, 2 insertions(+), 2 deletions(-)
> > >>
> > >> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> > >> index d9c169f..4875be5 100644
> > >> --- a/drivers/usb/host/xhci-plat.c
> > >> +++ b/drivers/usb/host/xhci-plat.c
> > >> @@ -197,7 +197,7 @@ static int xhci_plat_remove(struct platform_device *dev)
> > >>  	return 0;
> > >>  }
> > >>  
> > >> -#ifdef CONFIG_PM
> > >> +#ifdef CONFIG_PM_SLEEP
> > > 
> > > Can't you just remove these #ifdefs altogether?
> > > xhci_plat_pm_ops is set using SET_SYSTEM_SLEEP_PM_OPS() macro which
> > > already handles '#ifdef CONFIG_PM_SLEEP' case.
> > > 
> > It does handle the difference but the hooks implemented would
> > show-up un-used warning if you remove the #ifdefs.
> > 
> > drivers/usb/host/xhci-plat.c:200:12: warning: ‘xhci_plat_suspend’ defined but not used [-Wunused-function]
> > drivers/usb/host/xhci-plat.c:208:12: warning: ‘xhci_plat_resume’ defined but not used [-Wunused-function]
> > 
> > So you need to wrap them under the PM_SLEEP check.
> 
> Yeah... it's not smart enought :)
> But you could still remove the #else condition and the ugly DEV_PM_OPS
> macro.

Since this patch is not urgent, I sent a RFC proposing smarter
SET_*_PM_OPS(). I included your patch (a bit different) here:
https://patchwork.kernel.org/patch/3337961/

Br, David

> 
> Br, David
> 
> > 
> > Regards,
> > Santosh
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/