linux-kernel - Re: [PATCH 3/3] pinctrl: at91: implement at91_pinconf_dbg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52AACA73.9060409@atmel.com>
Date:	Fri, 13 Dec 2013 09:50:59 +0100
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	"Jean-Christophe Plagniol-Villard" <plagnioj@...osoft.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>
CC:	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 3/3] pinctrl: at91: implement at91_pinconf_dbg_show

On 07/12/2013 14:08, Alexandre Belloni :
> This allows to get the pin configuration by using debugfs. On my system:
>   # cat /sys/kernel/debug/pinctrl/pinctrl.3/pinconf-pins
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>

I am fine with these helpers:

Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>

But still a little disappointed that Laurent announced that he wouldn't 
review the whole kernel ;-)

Bye guys and thanks a lot!

> ---
>   drivers/pinctrl/pinctrl-at91.c | 25 +++++++++++++++++++++++++
>   1 file changed, 25 insertions(+)
>
> diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c
> index b0b78f3468ae..bcfc8a2eebca 100644
> --- a/drivers/pinctrl/pinctrl-at91.c
> +++ b/drivers/pinctrl/pinctrl-at91.c
> @@ -784,10 +784,35 @@ static int at91_pinconf_set(struct pinctrl_dev *pctldev,
>   	return 0;
>   }
>
> +#define DBG_SHOW_FLAG(flag) do {		\
> +	if (config & flag) {			\
> +		if (num_conf)			\
> +			seq_puts(s, "|");	\
> +		seq_puts(s, #flag);		\
> +		num_conf++;			\
> +	}					\
> +} while (0)
> +
>   static void at91_pinconf_dbg_show(struct pinctrl_dev *pctldev,
>   				   struct seq_file *s, unsigned pin_id)
>   {
> +	unsigned long config;
> +	int ret, val, num_conf = 0;
> +
> +	ret = at91_pinconf_get(pctldev, pin_id, &config);
> +
> +	DBG_SHOW_FLAG(MULTI_DRIVE);
> +	DBG_SHOW_FLAG(PULL_UP);
> +	DBG_SHOW_FLAG(PULL_DOWN);
> +	DBG_SHOW_FLAG(DIS_SCHMIT);
> +	DBG_SHOW_FLAG(DEGLITCH);
> +	DBG_SHOW_FLAG(DEBOUNCE);
> +	if (config & DEBOUNCE) {
> +		val = config >> DEBOUNCE_VAL_SHIFT;
> +		seq_printf(s, "(%d)", val);
> +	}
>
> +	return;
>   }
>
>   static void at91_pinconf_group_dbg_show(struct pinctrl_dev *pctldev,
>


-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/