linux-kernel - Re: [PATCH 5/5] drivers: misc: Mark function jp_generic_ide

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131213085811.GE4386@leaf>
Date:	Fri, 13 Dec 2013 00:58:11 -0800
From:	Josh Triplett <josh@...htriplett.org>
To:	Rashika Kheria <rashika.kheria@...il.com>
Cc:	linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 5/5] drivers: misc: Mark function jp_generic_ide_ioctl()
 as static in lkdtm.c

On Fri, Dec 13, 2013 at 12:29:42PM +0530, Rashika Kheria wrote:
> This patch marks the function jp_generic_ide_ioctl() as static in
> lkdtm.c because it is not used outside this file.
> 
> Thus, it also eliminates the following warnings in lkdtm.c:
> drivers/misc/lkdtm.c:227:5: warning: no previous prototype for ‘jp_generic_ide_ioctl’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>

Reviewed-by: Josh Triplett <josh@...htriplett.org>

>  drivers/misc/lkdtm.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/lkdtm.c b/drivers/misc/lkdtm.c
> index a2edb2e..79b677e 100644
> --- a/drivers/misc/lkdtm.c
> +++ b/drivers/misc/lkdtm.c
> @@ -224,7 +224,7 @@ static int jp_scsi_dispatch_cmd(struct scsi_cmnd *cmd)
>  }
>  
>  #ifdef CONFIG_IDE
> -int jp_generic_ide_ioctl(ide_drive_t *drive, struct file *file,
> +static int jp_generic_ide_ioctl(ide_drive_t *drive, struct file *file,
>  			struct block_device *bdev, unsigned int cmd,
>  			unsigned long arg)
>  {
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/