linux-kernel - Re: [PATCH 3/3] drivers: message: Mark functions as static in mptsas.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131213090130.GJ4386@leaf>
Date:	Fri, 13 Dec 2013 01:01:30 -0800
From:	Josh Triplett <josh@...htriplett.org>
To:	Rashika Kheria <rashika.kheria@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Nagalakshmi Nandigama <Nagalakshmi.Nandigama@....com>,
	Sreekanth Reddy <Sreekanth.Reddy@....com>, support@....com,
	DL-MPTFusionLinux@....com, linux-scsi@...r.kernel.org
Subject: Re: [PATCH 3/3] drivers: message: Mark functions as static in
 mptsas.c

On Fri, Dec 13, 2013 at 11:40:35AM +0530, Rashika Kheria wrote:
> This patch marks the function mptsas_refreshing_device_handles(),
> mptsas_expander_add() and mptsas_shutdown() as static in fusion/mptsas.c
> because they are not used outside this file.
> 
> Thus, it also eliminates the following warnings in fusion/mptsas.c:
> drivers/message/fusion/mptsas.c:1579:1: warning: no previous prototype for ‘mptsas_refreshing_device_handles’ [-Wmissing-prototypes]
> drivers/message/fusion/mptsas.c:3654:1: warning: no previous prototype for ‘mptsas_expander_add’ [-Wmissing-prototypes]
> drivers/message/fusion/mptsas.c:5327:1: warning: no previous prototype for ‘mptsas_shutdown’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>

Reviewed-by: Josh Triplett <josh@...htriplett.org>

>  drivers/message/fusion/mptsas.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/message/fusion/mptsas.c b/drivers/message/fusion/mptsas.c
> index dd239bd..906f448 100644
> --- a/drivers/message/fusion/mptsas.c
> +++ b/drivers/message/fusion/mptsas.c
> @@ -1575,7 +1575,7 @@ mptsas_del_end_device(MPT_ADAPTER *ioc, struct mptsas_phyinfo *phy_info)
>  	mptsas_port_delete(ioc, phy_info->port_details);
>  }
>  
> -struct mptsas_phyinfo *
> +static struct mptsas_phyinfo *
>  mptsas_refreshing_device_handles(MPT_ADAPTER *ioc,
>  	struct mptsas_devinfo *sas_device)
>  {
> @@ -3650,7 +3650,7 @@ mptsas_send_expander_event(struct fw_event_work *fw_event)
>   * @handle:
>   *
>   */
> -struct mptsas_portinfo *
> +static struct mptsas_portinfo *
>  mptsas_expander_add(MPT_ADAPTER *ioc, u16 handle)
>  {
>  	struct mptsas_portinfo buffer, *port_info;
> @@ -5323,7 +5323,7 @@ mptsas_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  	return error;
>  }
>  
> -void
> +static void
>  mptsas_shutdown(struct pci_dev *pdev)
>  {
>  	MPT_ADAPTER *ioc = pci_get_drvdata(pdev);
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/