linux-kernel - Re: [PATCH 3/8] regmap: Add support for using regmap over ssbi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131213104128.GT11044@sirena.org.uk>
Date:	Fri, 13 Dec 2013 10:41:28 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	Lee Jones <lee.jones@...aro.org>,
	Srinivas Ramana <sramana@...eaurora.org>,
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 3/8] regmap: Add support for using regmap over ssbi

On Thu, Dec 12, 2013 at 03:13:01PM -0800, Stephen Boyd wrote:

> > bulk_read() should decay to individual reads if there isn't a block
> > operaton and it's not like the hardware actually supports bulk reads
> > anyway.

> So regmap_bulk_read() should work if I don't have a map->bus? To make it
> work with reg_read/write I had to do this. I'm not sure how to make
> bulk_write work.

Yes, I'd expect the operation to work.  Your changes below are mostly
fine (we should add an additional check for values that aren't integer
numbers of bytes, I can add that) - can you send as a signed off patch
please and I'll apply?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)