| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <3708.1386950736@warthog.procyon.org.uk> Date: Fri, 13 Dec 2013 16:05:36 +0000 From: David Howells <dhowells@...hat.com> To: Jean Delvare <khali@...ux-fr.org> Cc: dhowells@...hat.com, linux-i2c@...r.kernel.org, rostedt@...dmis.org, linux-kernel@...r.kernel.org, Wolfram Sang <wolfram@...-dreams.de> Subject: Re: [PATCH] i2c: Add message transfer tracepoints for I2C and SMBUS Jean Delvare <khali@...ux-fr.org> wrote: > One significant difference between both implementations is that the old > one logs before the actual transfer, while yours logs afterward. While I > understand this allows you to log the result of the transfer, this also > means you'll miss the log if the actual transaction locks the system > (we've seen this before.) Something to think about... I could split each into three messages: - Write request (has params & data buffer) - Read request (has params but no data buffer) - Read reply (has data buffer only) It will make the transfer functions more complex, though, and will mean that, for i2c, you won't get all the replies to the messages in a batch in with the requests. I can also label the messages with the index number. Mostly I suspect this won't be a problem. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists