linux-kernel - Re: [PATCH 5/5] xfs: allow linkat() on O

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131213164154.GH20803@infradead.org>
Date:	Fri, 13 Dec 2013 08:41:54 -0800
From:	Christoph Hellwig <hch@...radead.org>
To:	Zhi Yong Wu <zwu.kernel@...il.com>
Cc:	xfs@....sgi.com, linux-fsdevel@...r.kernel.org,
	Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] xfs: allow linkat() on O_TMPFILE files

On Fri, Dec 13, 2013 at 10:27:53PM +0800, Zhi Yong Wu wrote:
> From: Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>
> 
> Enable O_TMPFILE support in linkat().
> For more info, please refer to:
>   http://oss.sgi.com/archives/xfs/2013-08/msg00341.html

Generall you should provide all reasonable information in the changelog
instead of linking to it.

> +	if (sip->i_d.di_nlink == 0)
> +		tres = &M_RES(mp)->tr_link_tmpfile;
> +	else
> +		tres = &M_RES(mp)->tr_link;

As mentioned before I think Dave wanted you to always use the same
reservation, but I'll leave that discussion to him.

> +/* For creating a link to an O_TMPFILE inode, except modifying
> + * those metadata for regular inode, we still need to remove an inode
> + * from unlinked list at first. That is,  we can modify:
> + *    the agi hash list and counters: sector size
> + *    the on disk inode before ours in the agi hash list: inode cluster size
> + */

We always have an emptry content

/*

line at the beginning of comments in XFS and the Linux kernel in
general.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/