linux-kernel - Re: [PATCH] scsi: integer overflow in megadev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yw1xbo0kinkv.fsf@unicorn.mansr.com>
Date:	Fri, 13 Dec 2013 18:59:44 +0000
From:	Måns Rullgård <mans@...sr.com>
To:	"Chen.Yu" <chyyuu@...il.com>
Cc:	linux-kernel@...r.kernel.org, levex@...ux.com, xiaoqixue_1@....com,
	fanwlexca@...il.com
Subject: Re: [PATCH] scsi: integer overflow in megadev_ioctl()

"Chen.Yu" <chyyuu@...il.com> writes:

> From: "Chen.Yu" <chyyuu@...il.com>
>
> There is a potential integer overflow in megadev_ioctl() if
> userspace passes in a large u32 variable uioc.adapno.
> The int variable adapno would < 0, leading to an error
> array access for hdb_soft_state[adapno], or an error
> copy_to_user(uioc.uioc_uaddr, mcontroller+adapno,..)
>
> Reported-by: Wenliang Fan <fanwlexca@...il.com>
> Suggested-by: Qixue Xiao <xiaoqixue_1@....com>
> Signed-off-by: Yu Chen <chyyuu@...il.com>
> Reviewed-by: Levente Kurusa <levex@...ux.com>
> ---
>  drivers/scsi/megaraid.c | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
> index 816db12..0b90c54 100644
> --- a/drivers/scsi/megaraid.c
> +++ b/drivers/scsi/megaraid.c
> @@ -3099,7 +3099,10 @@ megadev_ioctl(struct file *filep, unsigned int cmd, unsigned long arg)
>  		/*
>  		 * Which adapter
>  		 */
> -		if( (adapno = GETADAP(uioc.adapno)) >= hba_count )
> +		adapno = GETADAP(uioc.adapno);
> +		if( adapno < 0 )
> +			return (-EINVAL);
> +		if( adapno >= hba_count )
>  			return (-ENODEV);

This relies on implementation-defined behaviour when converting an
unsigned integer to signed integer.  A simpler and more robust fix is to
make the local variable 'adapno' unsigned.

-- 
Måns Rullgård
mans@...sr.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/