linux-kernel - Re: [PATCH 1/2] drivers: platform: Mark functions as static in hp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52AB8B91.1020608@tremplin-utc.net>
Date:	Fri, 13 Dec 2013 23:34:57 +0100
From:	Éric Piel <eric.piel@...mplin-utc.net>
To:	Rashika Kheria <rashika.kheria@...il.com>,
	Matthew Garrett <matthew.garrett@...ula.com>
CC:	Josh Triplett <josh@...htriplett.org>,
	linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH 1/2] drivers: platform: Mark functions as static in hp_accel.c

On 13-12-13 09:58, Josh Triplett wrote:
> On Fri, Dec 13, 2013 at 12:56:34PM +0530, Rashika Kheria wrote:
>> This patch marks the functions lis3lv02d_acpi_init(),
>> lis3lv02d_acpi_read() and lis3lv02d_acpi_write() as static in
>> x86/hp_accel.c because they are not used outside this file.
>>
>> Thus, it also eliminates the following warnings in x86/hp_accel.c:
>> drivers/platform/x86/hp_accel.c:91:5: warning: no previous prototype for ‘lis3lv02d_acpi_init’ [-Wmissing-prototypes]
>> drivers/platform/x86/hp_accel.c:109:5: warning: no previous prototype for ‘lis3lv02d_acpi_read’ [-Wmissing-prototypes]
>> drivers/platform/x86/hp_accel.c:132:5: warning: no previous prototype for ‘lis3lv02d_acpi_write’ [-Wmissing-prototypes]
>>
>> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
>
> Reviewed-by: Josh Triplett <josh@...htriplett.org>
Yes, looks fine.

Signed-off-by: Éric Piel <eric.piel@...mplin-utc.net>

Matthew, could you pick this patch up in the platform-driver-x86 branch?

Cheers,
Éric
>
>>   drivers/platform/x86/hp_accel.c |    6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/platform/x86/hp_accel.c b/drivers/platform/x86/hp_accel.c
>> index a8e43cf..01b619e 100644
>> --- a/drivers/platform/x86/hp_accel.c
>> +++ b/drivers/platform/x86/hp_accel.c
>> @@ -88,7 +88,7 @@ MODULE_DEVICE_TABLE(acpi, lis3lv02d_device_ids);
>>    *
>>    * Returns 0 on success.
>>    */
>> -int lis3lv02d_acpi_init(struct lis3lv02d *lis3)
>> +static int lis3lv02d_acpi_init(struct lis3lv02d *lis3)
>>   {
>>   	struct acpi_device *dev = lis3->bus_priv;
>>   	if (acpi_evaluate_object(dev->handle, METHOD_NAME__INI,
>> @@ -106,7 +106,7 @@ int lis3lv02d_acpi_init(struct lis3lv02d *lis3)
>>    *
>>    * Returns 0 on success.
>>    */
>> -int lis3lv02d_acpi_read(struct lis3lv02d *lis3, int reg, u8 *ret)
>> +static int lis3lv02d_acpi_read(struct lis3lv02d *lis3, int reg, u8 *ret)
>>   {
>>   	struct acpi_device *dev = lis3->bus_priv;
>>   	union acpi_object arg0 = { ACPI_TYPE_INTEGER };
>> @@ -129,7 +129,7 @@ int lis3lv02d_acpi_read(struct lis3lv02d *lis3, int reg, u8 *ret)
>>    *
>>    * Returns 0 on success.
>>    */
>> -int lis3lv02d_acpi_write(struct lis3lv02d *lis3, int reg, u8 val)
>> +static int lis3lv02d_acpi_write(struct lis3lv02d *lis3, int reg, u8 val)
>>   {
>>   	struct acpi_device *dev = lis3->bus_priv;
>>   	unsigned long long ret; /* Not used when writting */
>> --
>> 1.7.9.5
>>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/