linux-kernel - Re: [PATCH 0/2] ipmi: fix timeout calculation when bmc is disconnected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52AA7BC7.4080000@acm.org>
Date:	Thu, 12 Dec 2013 21:15:19 -0600
From:	Corey Minyard <minyard@....org>
To:	Xie XiuQi <xiexiuqi@...wei.com>
CC:	Hushiyuan <hushiyuan@...wei.com>,
	openipmi-developer@...ts.sourceforge.net,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Zhangdianfang <zhangdianfang@...wei.com>
Subject: Re: [PATCH 0/2] ipmi: fix timeout calculation when bmc is disconnected

Both look good, thank you.  I've queued them for the next window.

-corey

On 12/12/2013 08:36 PM, Xie XiuQi wrote:
> Hu Shiyuan report, when loading ipmi_si module while bmc is
> disconnected, we found the timeout is longer than 5 secs.
> Actually it takes about 3 mins and 20 secs (HZ=250).
>
> error message as below:
> Dec 12 19:08:59 linux kernel: IPMI BT: timeout in RD_WAIT [ ] 1 retries left
> Dec 12 19:08:59 linux kernel: BT: write 4 bytes seq=0x01 03 18 00 01
> [...]
> Dec 12 19:12:19 linux kernel: IPMI BT: timeout in RD_WAIT [ ]
> Dec 12 19:12:19 linux kernel: failed 2 retries, sending error response
> Dec 12 19:12:19 linux kernel: IPMI: BT reset (takes 5 secs)
> Dec 12 19:12:19 linux kernel: IPMI BT: flag reset [ ]
>
> Function wait_for_msg_done() use schedule_timeout_uninterruptible(1)
> to sleep 1 tick, so we should subtract jiffies_to_usecs(1) usecs
> instead of 100 usecs from timeout.
>
> For more clearly, I used USEC_PER_SEC instead of 1000000.
>
> Xie XiuQi (2):
>   ipmi: use USEC_PER_SEC instead of 1000000 for more meaningful
>   ipmi: fix timeout calculation when bmc is disconnected
>
>  drivers/char/ipmi/ipmi_bt_sm.c   | 8 ++++----
>  drivers/char/ipmi/ipmi_kcs_sm.c  | 4 ++--
>  drivers/char/ipmi/ipmi_si_intf.c | 2 +-
>  drivers/char/ipmi/ipmi_smic_sm.c | 2 +-
>  4 files changed, 8 insertions(+), 8 deletions(-)
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/