linux-kernel - Re: [PATCH] drm/bochs: new driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201312130330.14647.s.L-H@gmx.de>
Date:	Fri, 13 Dec 2013 03:30:07 +0000
From:	"Stefan Lippers-Hollmann" <s.L-H@....de>
To:	Gerd Hoffmann <kraxel@...hat.com>
Cc:	David Airlie <airlied@...ux.ie>,
	open list <linux-kernel@...r.kernel.org>,
	"open list:DRM DRIVERS" <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH] drm/bochs: new driver

Hi

On Thursday 12 December 2013, Gerd Hoffmann wrote:
> DRM driver for (virtual) vga cards using the bochs dispi
> interface, such as the qemu standard vga (qemu -vga std).
> 
> Don't bother supporting anything but 32bpp for now, even
> though the virtual hardware is able to do that.
> 
> Known issue: mmap(/dev/fb0) doesn't work.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@...hat.com>
> ---
[…]
> diff --git a/drivers/gpu/drm/bochs/bochs_mm.c b/drivers/gpu/drm/bochs/bochs_mm.c
> new file mode 100644
> index 0000000..afe104f
> --- /dev/null
> +++ b/drivers/gpu/drm/bochs/bochs_mm.c
[…]
> +int bochs_gem_create(struct drm_device *dev, u32 size, bool iskernel,
> +		     struct drm_gem_object **obj)
> +{
> +	struct bochs_bo *bochsbo;
> +	int ret;
> +
> +	*obj = NULL;
> +
> +	size = roundup(size, PAGE_SIZE);
[…]

Using roundup() this way will fail to build in 32 bit architectures/ 
i386:

ERROR: "__udivdi3" [drivers/gpu/drm/bochs/bochs-drm.ko] undefined!
ERROR: "__umoddi3" [drivers/gpu/drm/bochs/bochs-drm.ko] undefined!

[drm/bochs works pretty nicely for me on amd64]

Regards
	Stefan Lippers-Hollmann
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/