lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Dec 2013 23:15:54 -0500 From: Naoya Horiguchi <n-horiguchi@...jp.nec.com> To: Jianguo Wu <wujianguo@...wei.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, Mel Gorman <mgorman@...e.de>, Andi Kleen <andi@...stfloor.org>, gong.chen@...ux.intel.com, Wanpeng Li <liwanp@...ux.vnet.ibm.com>, linux-mm@...ck.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] mm/memory-failure.c: recheck PageHuge() after hugetlb page migrate successfully On Fri, Dec 13, 2013 at 11:36:36AM +0800, Jianguo Wu wrote: > Changelog: > - Only set PageHWPoison on the error raw page if page is freed into buddy > > After a successful hugetlb page migration by soft offline, the source page > will either be freed into hugepage_freelists or buddy(over-commit page). > If page is in buddy, page_hstate(page) will be NULL. It will hit a NULL > pointer dereference in dequeue_hwpoisoned_huge_page(). > > [ 890.677918] BUG: unable to handle kernel NULL pointer dereference at > 0000000000000058 > [ 890.685741] IP: [<ffffffff81163761>] > dequeue_hwpoisoned_huge_page+0x131/0x1d0 > [ 890.692861] PGD c23762067 PUD c24be2067 PMD 0 > [ 890.697314] Oops: 0000 [#1] SMP > > So check PageHuge(page) after call migrate_pages() successfully. > > Tested-by: Naoya Horiguchi <n-horiguchi@...jp.nec.com> > Cc: stable@...r.kernel.org > Signed-off-by: Jianguo Wu <wujianguo@...wei.com> Thanks! Reviewed-by: Naoya Horiguchi <n-horiguchi@...jp.nec.com> > --- > mm/memory-failure.c | 14 ++++++++++---- > 1 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index b7c1716..db08af9 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -1505,10 +1505,16 @@ static int soft_offline_huge_page(struct page *page, int flags) > if (ret > 0) > ret = -EIO; > } else { > - set_page_hwpoison_huge_page(hpage); > - dequeue_hwpoisoned_huge_page(hpage); > - atomic_long_add(1 << compound_order(hpage), > - &num_poisoned_pages); > + /* overcommit hugetlb page will be freed to buddy */ > + if (PageHuge(page)) { > + set_page_hwpoison_huge_page(hpage); > + dequeue_hwpoisoned_huge_page(hpage); > + atomic_long_add(1 << compound_order(hpage), > + &num_poisoned_pages); > + } else { > + SetPageHWPoison(page); > + atomic_long_inc(&num_poisoned_pages); > + } > } > return ret; > } > -- > 1.7.1 > > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@...ck.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists