linux-kernel - Re: [PATCH v2 1/1] ARM: dts: Add missing clocks for exynos4412 dwmmc node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6057819.pWzq25qpVf@flatron>
Date:	Sat, 14 Dec 2013 14:24:23 +0100
From:	Tomasz Figa <tomasz.figa@...il.com>
To:	Alex Ling <kasimling@...il.com>
Cc:	ben-linux@...ff.org, kgene.kim@...sung.com,
	rob.herring@...xeda.com, pawel.moll@....com, mark.rutland@....com,
	linux@....linux.org.uk, linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] ARM: dts: Add missing clocks for exynos4412 dwmmc node

Hi Alex,

On Saturday 14 of December 2013 13:21:30 Alex Ling wrote:
> This patch adds "biu" and "ciu" clocks for exynos4412 dwmmc
> node. Without this patch, dwmmc host driver will skip enabling the
> two clocks and it will break dwmmc host function on exynos4412.
> Tested on FriendlyARM TINY4412 board.
> 
> Signed-off-by: Alex Ling <kasimling@...il.com>
> ---
> Changes for v2:
>    - Fix patch description as Mark Rutland suggested
> 
>  arch/arm/boot/dts/exynos4412.dtsi |    2 ++
>  1 file changed, 2 insertions(+)

The patch is correct, but unfortunately it's not the only thing that
is wrong with MSHC device tree node for Exynos4x12.

Please refer to my series fixing DW-MSHC support on Exynos4x12 (and
enabling it on TRATS2 board):
http://www.spinics.net/lists/arm-kernel/msg293652.html

Best regards,
Tomasz

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/