linux-kernel - Re: [PATCH 001/115] gpu: ion: Add ION Memory Manager

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52ABB1C8.1060406@linaro.org>
Date:	Fri, 13 Dec 2013 17:18:00 -0800
From:	John Stultz <john.stultz@...aro.org>
To:	Greg KH <gregkh@...uxfoundation.org>
CC:	LKML <linux-kernel@...r.kernel.org>,
	Android Kernel Team <kernel-team@...roid.com>,
	Sumit Semwal <sumit.semwal@...aro.org>,
	Jesse Barker <jesse.barker@....com>,
	Colin Cross <ccross@...roid.com>,
	Rebecca Schultz Zavin <rebecca@...roid.com>
Subject: Re: [PATCH 001/115] gpu: ion: Add ION Memory Manager

On 12/13/2013 03:50 PM, Greg KH wrote:
> On Fri, Dec 13, 2013 at 02:23:35PM -0800, John Stultz wrote:
>> From: Rebecca Schultz Zavin <rebecca@...roid.com>
>>
>> Signed-off-by: Rebecca Schultz Zavin <rebecca@...roid.com>
>> [jstultz: Squished in Colin Cross' move to staging change]
>> Signed-off-by: John Stultz <john.stultz@...aro.org>
>> ---
>>  drivers/staging/android/Kconfig                 |    2 +
>>  drivers/staging/android/Makefile                |    2 +
> This patch breaks the build if this option is enabled.
>
> I suggest only adding the driver to the build _after_ it can be built,
> for obvious reasons :)
>
> Other than this "minor" thing, I have no objection to these patches at
> all.  Can you redo this patch to fix this up, and maybe send another
> patch adding it to the build and let me know at what point in the series
> it should be applied?

Ok. Two patches attached.  I ended up just yanking the build directory
since disabling the config option caused trivial collisions in the series.


0001-ion-Disable-ION-as-it-doesn-t-build.patch  - This can be folded in
after the first patch.


0117-ion-Reenable-the-build.patch - This can be applied to the end of
the series, or folded into the last patch "ion: Update system heap
shrinker to use the new count/scan interface"

Let me know if you'd rather this be done some other way.  Also let me
know if you've still not seen the other patches in the series.

thanks
-john


View attachment "0001-ion-Disable-ION-as-it-doesn-t-build.patch" of type "text/x-diff" (975 bytes)

View attachment "0117-ion-Reenable-the-build.patch" of type "text/x-diff" (846 bytes)