linux-kernel - Re: [PATCH] libata, freezer: avoid block device removal while system is frozen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131214015518.GQ31386@dastard>
Date:	Sat, 14 Dec 2013 12:55:18 +1100
From:	Dave Chinner <david@...morbit.com>
To:	Nigel Cunningham <nigel@...elcunningham.com.au>
Cc:	Tejun Heo <tj@...nel.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Jens Axboe <axboe@...nel.dk>, tomaz.solc@...lix.org,
	aaron.lu@...el.com, linux-kernel@...r.kernel.org,
	Oleg Nesterov <oleg@...hat.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Fengguang Wu <fengguang.wu@...el.com>
Subject: Re: [PATCH] libata, freezer: avoid block device removal while system
 is frozen

On Sat, Dec 14, 2013 at 10:15:21AM +1100, Nigel Cunningham wrote:
> Hi again.
> 
> On 14/12/13 10:07, Tejun Heo wrote:
> >Hello, Nigel.
> >
> >On Sat, Dec 14, 2013 at 09:45:59AM +1100, Nigel Cunningham wrote:
> >>In your first email, in the first substantial paragraph (starting
> >>"Now, if the rest.."), you say "libata device removal waits for the
> >>scheduled writeback work item to finish". I wonder if that's the
> >>lynchpin. If we know the device is gone, why are we trying to write
> >>to it?
> >It's just a standard part of block device removal -
> >invalidate_partition(), bdi_wb_shutdown().
> Mmm. But perhaps there needs to be some special code in there to
> handle the "we can't write to this device anymore" case?

I've been asking for that "special code" for years, Nigel... :/

Cheers,

Dave.
-- 
Dave Chinner
david@...morbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/